Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't find options when nested in an addon #28

Closed
mattxyzeth opened this issue Jan 20, 2016 · 2 comments
Closed

Can't find options when nested in an addon #28

mattxyzeth opened this issue Jan 20, 2016 · 2 comments

Comments

@mattxyzeth
Copy link
Contributor

I tried installing this addon in another addon so I could provide vendored styles but the include method failed because it was trying to find the options hash on the app and the app doesn't include this when nested.

I've created a quick MR #27 to allow this addon to switch to the app's app property to get the options.
@kimroen
Copy link
Owner

kimroen commented Feb 21, 2016

Thanks for your fix - this has been released as v0.6.0.

@kimroen kimroen closed this as completed Feb 21, 2016
@mattxyzeth
Copy link
Contributor Author

Sweet!

On Feb 21, 2016, at 9:51 AM, Kim Røen notifications@github.com wrote:

Thanks for your fix - this has been released as v0.6.0.

—
Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kimroen @mattxyzeth