Bump broccoli-autoprefixer to v5 & drop node .12 support #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Any objections @kimroen? |
|
Hi @kimroen - is there anything that I could do to get this merged? Happy to discuss or make adjustments. Thank you! |
|
Hi Kyle! Thanks for looking at this. Sorry I've been slow at getting back to you here—I'll check it out now. |
kimroen
approved these changes
Aug 26, 2017
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "ember-cli-autoprefixer", | |||
| "version": "0.7.0", | |||
| "version": "0.8.0", | |||
There was a problem hiding this comment.
In the future, please don't bump the version number of the package in the PR ✨
There was a problem hiding this comment.
Ok, noted. Thanks for the merge!
|
Merged in 41f7edc, without the version bump to ember-cli-autoprefixer. Thanks again! I'll update the changelog and release a new version. |
|
This is now released as version 0.8.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of #36 - I'm not seeing the flickering tests (https://travis-ci.org/kyleshay/ember-cli-autoprefixer/builds - failing test was testing against
node .12)Similar to #36: I also updated travis.yml to drop
node 0.12support per postcss/autoprefixer@6439ded and sindresorhus/broccoli-autoprefixer@6d06065#36 also bumps the ember bower/npm dependencies, but I'm leaving that out of this PR for now.
Tests may be failing in #36 due to something related to ember-cli/ember-cli#5023 should eventually consider bumping ember-cli