Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect ordering #41

Open
stefanpenner opened this issue Jun 7, 2018 · 4 comments
Open

Incorrect ordering #41

stefanpenner opened this issue Jun 7, 2018 · 4 comments
Labels

Comments

@stefanpenner
Copy link

Something seems funky. By default, it appears that ember-cli-autoprefixer is run after minification of css. This results in comment based autoprefixer declarations such as /*! autoprefixer: */` not making their way down to autoprefixer.

h2. Questions:

  • is it possible to move this to a preprocess step, but using after/before clause in addons package.json, ensure it happens at the right phase? Specifically other addons such as ember-cli-eyeglass etc would need to declare ^
  • does ember-cli need a hook/milestone to have this run explicitly before minification?
@acorncom
Copy link

@stefanpenner did you ever get this resolved? I'm quite interested in using this for a client project ...

@acorncom
Copy link

Based on #39 it seems like ensuring this runs before minification/fingerprinting would be helpful ...

@snewcomer snewcomer added the bug label Feb 17, 2020
@snewcomer
Copy link
Collaborator

Do we need a before entry for broccoli-clean-css?

https://github.com/shinnn/broccoli-clean-css

@nlfurniss
Copy link
Contributor

I believe that's what @stefanpenner found (though he should correct me if my memory is wrong)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants