Skip to content
This repository has been archived by the owner on Sep 12, 2020. It is now read-only.

Upload fails on 4.0.0 #264

Closed
latica-jp opened this issue Jan 31, 2020 · 2 comments · Fixed by #266
Closed

Upload fails on 4.0.0 #264

latica-jp opened this issue Jan 31, 2020 · 2 comments · Fixed by #266
Assignees
Labels
bug Something isn't working

Comments

@latica-jp
Copy link

latica-jp commented Jan 31, 2020

On 3.0.6 - 4.0.0, plugin upload fails with following error:

Open https://mydomain.cybozu.com/login?saml=off
Trying to log in...
Navigate to https://mydomain.cybozu.com/k/admin/system/plugin/
Trying to upload ./dist/plugin.zip
エラーが発生しました { TimeoutError: waiting for selector ".ocean-ui-dialog" to be hidden failed: timeout 5000ms exceeded
    at new WaitTask (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/DOMWorld.js:549:28)
    at DOMWorld._waitForSelectorOrXPath (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/DOMWorld.js:478:22)
    at DOMWorld.waitForSelector (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/DOMWorld.js:432:17)
    at Frame.waitForSelector (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/FrameManager.js:627:47)
    at Frame.<anonymous> (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/helper.js:112:23)
    at Page.waitForSelector (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/puppeteer/lib/Page.js:1120:29)
    at /Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/@kintone/plugin-uploader/dist/index.js:81:20
    at Generator.next (<anonymous>)
    at fulfilled (/Users/isao/Documents/kintone Projects/kintone-plugin-template/node_modules/@kintone/plugin-uploader/dist/index.js:5:58)
    at process._tickCallback (internal/process/next_tick.js:68:7) name: 'TimeoutError' }

Besides, 3.0.5 w/ puppeteer 1.19.0 works fine.

I've confirmed that elementHandle.uploadFile doesn't work as expected after 3.0.6, so it seems to be a puppeteer's problem.

Steps to reproduce

npx kintone-plugin-uploader --domain mydomain.cybozu.com --username USERNAME --password PASSWORD RELATIVE_PATH_TO_PLUGIN_ZIP

@zaki-yama zaki-yama added the bug Something isn't working label Jan 31, 2020
@zaki-yama zaki-yama self-assigned this Jan 31, 2020
@zaki-yama
Copy link
Contributor

@latica-jp
Thank you for reporting!
As you have guessed, it seems to be a puppeteer's problem.
The issue is here: puppeteer/puppeteer#5363

Since the issue was already closed, we will wait for the new version of puppeteer to be published.
If the fixed version isn't released in a few days, we'll downgrade puppeteer temporarily.

We'll notify you if there is any progress.

@koba04
Copy link
Contributor

koba04 commented Feb 10, 2020

@latica-jp
I've pinned puppeteer version v1 to avoid this issue and have released it as v4.0.1.
I'll work on updating puppeteer to the latest version later.
Thank you for your contribution!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants