Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a stream on uploadFile in browsers #1746

Open
ueokande opened this issue Sep 28, 2022 · 1 comment
Open

Support a stream on uploadFile in browsers #1746

ueokande opened this issue Sep 28, 2022 · 1 comment
Labels
feature New feature pkg: rest-api-client @kintone/rest-api-client

Comments

@ueokande
Copy link
Member

Package

  • @kintone/rest-api-client 3.1.11

Why

https://github.com/kintone/js-sdk/blob/master/packages/rest-api-client/docs/file.md#uploadFile

Stream is only available in Node.js environment.

Uploading files from local filesystem and stream is supported is only available in Node.js. This can cause increase heap memory usage.

What

Most modern browsers support WritableStream. This is helpful to reduce memory usage in browsers.
@ueokande ueokande added feature New feature pkg: rest-api-client @kintone/rest-api-client labels Sep 28, 2022
@tasshi-me
Copy link
Member

In Node.js, WritableStream is experimental (stability 1).
Also, we have to drop Node 14.x support for supporting WritableStream on Node.js.
https://developer.mozilla.org/ja/docs/Web/API/Streams_API#writablestream_2

@tasshi-me tasshi-me mentioned this issue Oct 13, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature pkg: rest-api-client @kintone/rest-api-client
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ueokande @tasshi-me