Skip to content
This repository has been archived by the owner on Oct 21, 2020. It is now read-only.

Fix Issue#264 Make id and type optional properties #285

Closed
wants to merge 1 commit into from

Conversation

yokotaso
Copy link
Contributor

@yokotaso yokotaso requested a review from a team as a code owner May 17, 2020 01:51
@yokotaso yokotaso requested review from koba04 and chick-p and removed request for a team May 17, 2020 01:51
@koba04
Copy link
Contributor

koba04 commented May 17, 2020

@yokotaso
Thank you for this PR!

Currently, we consider providing another type for the use-case for updating because changing these properties optional leads the use-case for reference inconvenient.

Changing these types optional also leads the usage inconvenient because it requires to check whether the type exists or not and disables to infer using discriminated unions.
If the use case is a type for updating, it seems to be a good option to add another type for it

https://github.com/kintone/dts-gen/issues/264#issuecomment-620467282

What do you think?

@yokotaso
Copy link
Contributor Author

@koba04
I see. I agree with you. I reimplement this issue, thank you.

@koba04 koba04 closed this Sep 18, 2020
@koba04
Copy link
Contributor

koba04 commented Sep 18, 2020

We'll migrate this repo into kintone/js-sdk, so we'll work on this at kintone/js-sdk in the future. Thank you!

@koba04 koba04 deleted the Issue-264 branch September 18, 2020 05:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SUBTABLE field requires type and value.id
2 participants