Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrading to eslint v6 requires --ext js,jsx,ts,tsx to lint anything other than js #4

Open
kiprasmel opened this issue Feb 2, 2020 · 0 comments
Open

Upgrading to eslint v6 requires --ext js,jsx,ts,tsx to lint anything other than js #4

kiprasmel opened this issue Feb 2, 2020 · 0 comments
Assignees
@kiprasmel
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@kiprasmel
Copy link
Owner

kiprasmel commented Feb 2, 2020 •
edited

Issue originally reported by @okovalov 🔥

This is important because of #3.

It's nothing much if you have an npm script as a proxy for calling eslint, but for a global setup it's pretty annoying.

It sucks that you cannot just provide the desired extensions in the config itself - this will hopefully be available with eslint v7.
@kiprasmel kiprasmel added bug Something isn't working documentation Improvements or additions to documentation labels Feb 2, 2020
@kiprasmel kiprasmel self-assigned this Feb 2, 2020
@kiprasmel kiprasmel mentioned this issue Feb 2, 2020
Open
3 tasks
kiprasmel added a commit that referenced this issue Feb 2, 2020
@kiprasmel
Add react's package.json instruction to append --ext js,jsx,ts,tsx …
e42a543 
…option to eslint

See #4 (#4)

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
kiprasmel added a commit that referenced this issue Feb 2, 2020
@kiprasmel
Add react's package.json instruction to append --ext js,jsx,ts,tsx …
119d184 
…option to eslint

See #4 (#4)

Also updated this project's package.json - the change is not needed for
eslint v5, but it's compatible with both v5 & v6, so it won't hurt.

Signed-off-by: Kipras Melnikovas <kipras@kipras.org>
@kiprasmel kiprasmel mentioned this issue Feb 2, 2020
Merged
kiprasmel added a commit that referenced this issue Feb 2, 2020
@kiprasmel
Merge pull request #5 from sarpik/sarpik/create-react-app-docs-update
3f5c90e 
See:

* #3 
* #4
@kiprasmel kiprasmel mentioned this issue Feb 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kiprasmel kiprasmel

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kiprasmel