Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Cannot find name 'OffscreenCanvas' in new project #2485

Closed
1 of 9 tasks
lcersly opened this issue Sep 19, 2022 · 3 comments
Closed
1 of 9 tasks

[BUG] Cannot find name 'OffscreenCanvas' in new project #2485

lcersly opened this issue Sep 19, 2022 · 3 comments
Assignees
Labels
bug NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild

Comments

@lcersly
Copy link

lcersly commented Sep 19, 2022

Describe the bug

Installing Kirby design breaks angular build.

Describe how to reproduce the bug

  1. npx @angular/cli@13 new kirby-project
  2. cd kirby-project
  3. npm i @kirbydesign/designsystem
  4. Import KirbyModule under imports in app.module.ts
  5. ng serve

Which Kirby version was used?

7.0.1

What was the expected behavior?

Build succeeded

Add any screenshots

image

Please complete the following information:

  • OS: Windows

Are there any additional context?

It seems to be caused by an old version of chart.js


Checklist:

The following tasks should be carried out in sequence in order to follow the process of contributing correctly.

Verification

To make sure the bug is not intended behaviour; it should be verified by a member of team Kirby before moving on to implementation.

  • Make sure the NOT verified label has been removed by a member of team Kirby; do not proceed until this is done

Implementation

The contributor who wants to implement this issue should:

Review

Once the issue has been implemented and is ready for review:

@lcersly lcersly added bug NOT Prioritized Issue not yet prioritized and added to a Milestone NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild labels Sep 19, 2022
@RasmusKjeldgaard
Copy link
Collaborator

Thank you for reporting this, we need to fix that asap.

Until then a (less than ideal) workaround is to add "skipLibCheck": true to your tsconfig compiler options.

@alxzak alxzak removed the NOT Prioritized Issue not yet prioritized and added to a Milestone label Sep 27, 2022
@RasmusKjeldgaard
Copy link
Collaborator

Just adding to this: As already mentioned in the original issue, this should be fixed by updating Chart.js. More specifically to version 3.6 or later

@RasmusKjeldgaard
Copy link
Collaborator

When bumping chart.js, remember to remove the "skipLibCheck": true flag from our tsconfigs so this does not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug NOT Verified Applied to bug reports that have not been verified by a member of @kirbydesign/kirby-guild
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants