Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux Toolkit example is unclear #557

Open
hypnoboutique opened this issue Aug 29, 2023 · 0 comments
Open

Redux Toolkit example is unclear #557

hypnoboutique opened this issue Aug 29, 2023 · 0 comments
Labels

Comments

@hypnoboutique
Copy link

hypnoboutique commented Aug 29, 2023

Describe the bug

There is a full example of implentation with redux tool kit here (mentioned in the readme). But the example contains the following comment, with no further explanation:

//FIXME This is not a recommended approach, only used here for demo purposes

As a result, I'm unclear about how to implement next-redux-wrapper with RTK correctly (which I'm trying to do to silence a warning about using the legacy withRedux method).

To Reproduce

  1. Click link in this line of the ReadMe
  2. Navigate to pages/_app.tsx
  3. See FIXME comment and no explanation of what is the recommended implementation

Expected behavior

a) A clear and concise description of how to implement with redux toolkit
OR
b) removal of this warning, if we should/can continue to use withRedux.

Screenshots

n/a

Desktop (please complete the following information):

n/a

Additional context

n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant