Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary version bumps of @kiwicom/babel-plugin-orbit-components #2368

Closed
silvenon opened this issue Oct 19, 2020 · 1 comment · Fixed by #2383
Closed

Avoid unnecessary version bumps of @kiwicom/babel-plugin-orbit-components #2368

silvenon opened this issue Oct 19, 2020 · 1 comment · Fixed by #2383
Assignees
@sampi

Comments

@silvenon
Copy link
Contributor

silvenon commented Oct 19, 2020 •
edited

@kiwicom/babel-plugin-orbit-components always gets a version bump because it has @kiwicom/orbit-components in devDependencies. It will probably be enough to remove it, otherwise we should consider removing all devDependencies from both packages.

Success can be checked by running yarn release, then seeing whether the version is unjustifiably bumped.

lerna/lerna#1737
@sampi
Copy link
Contributor

sampi commented Oct 21, 2020

I'll take a look, if it can be done quickly

@sampi sampi self-assigned this Oct 21, 2020
@sampi sampi mentioned this issue Oct 21, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sampi sampi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(BabelPlugin): remove internal dependency kiwicom/orbit
2 participants
@silvenon @sampi