Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#minor Remove unnecessary sleep before each watch cycle #326

Merged
merged 1 commit into from Feb 28, 2024

Conversation

ahtohio
Copy link

@ahtohio ahtohio commented Feb 13, 2024

During my work with this project I've discovered that some DELETE k8s events are skipped for unknown reason.
After some digging, I've managed to discover that if a DELETE event is sent while sidecar in its 5 seconds sleep between watch cycles, this event is simply gets skipped. There's no one to receive it. And after ERROR_THROTTLE_SLEEP seconds watch cycle starts, receives all modified and added k8s resources, but it doesn't get any events about deleted stuff.
And sidecar lacks a reconciliation loop to handle deleted resources based on received list of resources.

By shifting sleep throttle to only exceptions case we should manage to catch most of the DELETE events.

@ChristianGeie
Copy link
Collaborator

lgtm.
@jekkel we recently talked about the fact that files had not been deleted from the file system, even though the source configmap had already been deleted. Surely this would address such a problem?

@ChristianGeie ChristianGeie added bug Something isn't working question Further information is requested python Pull requests that update Python code labels Feb 26, 2024
Copy link
Member

@jekkel jekkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, LGTM

@ChristianGeie ChristianGeie merged commit ac2354a into kiwigrid:master Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python Pull requests that update Python code question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants