Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create only one reader and use it everywhere #3536

Open
kelson42 opened this issue Nov 17, 2023 · 0 comments · May be fixed by #3624
Open

Create only one reader and use it everywhere #3536

kelson42 opened this issue Nov 17, 2023 · 0 comments · May be fixed by #3624
Assignees
@MohitMaliFtechiz
Labels
enhancement question
Milestone
3.12.0

Comments

@kelson42
Copy link
Collaborator

kelson42 commented Nov 17, 2023 •
edited

During the migration from access ZIM file via path to access ZIM file via filedescriptor, it appears that each feature has its own way to access the ZIM files. This is seems wrong because yhis is uselessly complicated and bug prone (what actually happened).

It should be like this:

  • One handler/reader per ZIM file for the whole app and all its features
  • Once place to open a file/create/destroy this handler

See also: #3535
@kelson42 kelson42 added this to the 3.9.0 milestone Nov 17, 2023
@kelson42 kelson42 modified the milestones: 3.9.0, 3.10.0 Dec 14, 2023
@MohitMaliFtechiz MohitMaliFtechiz linked a pull request Dec 21, 2023 that will close this issue
Open
@kelson42 kelson42 modified the milestones: 3.10.0, 3.11.0 Mar 20, 2024
@kelson42 kelson42 modified the milestones: 3.11.0, 3.12.0 May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MohitMaliFtechiz MohitMaliFtechiz

Labels
enhancement question
Projects
None yet
Milestone
3.12.0
Development

Successfully merging a pull request may close this issue.

Fixed: Create only one reader and use it everywhere. kiwix/kiwix-android
2 participants
@kelson42 @MohitMaliFtechiz