Skip to content

Commit

Permalink
fix: Fix devServer setupMiddlewares issue.
Browse files Browse the repository at this point in the history
  • Loading branch information
jaywcjlove committed Sep 20, 2022
1 parent 41c10ad commit baf14e3
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions core/src/scripts/start.ts
Expand Up @@ -99,6 +99,7 @@ export default async function start(argvs: StartArgs) {
}
delete serverConf.onAfterSetupMiddleware;
delete serverConf.onBeforeSetupMiddleware;
const setupMiddlewares = overrideDevServerConfig.setupMiddlewares;
serverConf.setupMiddlewares = (middlewares, devServer) => {
// Keep `evalSourceMapMiddleware`
// middlewares before `redirectServedPath` otherwise will not have any effect
Expand All @@ -122,6 +123,9 @@ export default async function start(argvs: StartArgs) {
// it used the same host and port.
// https://github.com/facebook/create-react-app/issues/2272#issuecomment-302832432
devServer.app.use(noopServiceWorkerMiddleware(paths.publicUrlOrPath));
if (setupMiddlewares) {
return setupMiddlewares(middlewares, devServer);
}
return middlewares;
};
return serverConf;
Expand Down
4 changes: 4 additions & 0 deletions example/react-component-tsx/.kktrc.ts
Expand Up @@ -31,5 +31,9 @@ export default (conf: Configuration, env: 'development' | 'production', options:
*/
export const devServer = (config: WebpackDevServer.Configuration) => {
// Return your customised Webpack Development Server config.
// setupMiddlewares Example
config.setupMiddlewares = (middlewares, server) => {
return middlewares;
};
return config;
};

0 comments on commit baf14e3

Please sign in to comment.