New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not print version check when generating completions #447
Comments
Hey @benedikt-bartscher, happy to hear you like it :) May I ask how you found it? And Kluctl printing the version in the completion command is clearly not intended and I'll fix it next week. Should also be an easy fix for new contributors if someone is interested. |
Of course, i think i discovered it trough one of your reddit comments where someone was struggeling with flux, helm and kustomize. I just migrated some dev workloads to kluctl and it works fine so far. Is it possible that completion doesn't work at all currently with zsh? I haven't investigated further yet, but even if i remove the version output completions do not work for me (only file completions shown) |
I have merged #442 today which upgrades the library that I use for the CLI and completions. This upgrade brings in spf13/cobra#1917, which seems to fix issues with sourcing of zsh completion scripts...which seems to be what you're doing. I assume that the next Kluctl release will then fix your issues as well. You say you tested disabling the version output...are you self-compiling already? If yes, can you retry with the current main branch? |
Oh and btw, I googled for the company you work for and it turns out it's in Dortmund. I'll do a talk in Düsseldorf on the 16. of May, maybe you'd like to join as well :) |
Yes of course i am self-compiling, i did some temp tweaks to test/debug stuff. Thank you, i will try the main branch later and report back. Nice, thank you for inviting me to the talk. Maybe i will join but we are pretty busy currently. |
This issue got auto-closed now, feel free to re-open it or open another one when completion is still not working for you. |
Operating system
Arch Linux
Kluctl Version
2.19.3
Kubernetes Version
v1.26.4
kubectl Version
v1.27.1
Bug description
Hey there, first of all thank you for the missing glue @codablock. I am happy that i found kluctl after some hours of fiddeling around with flux and kustomize.
Could you adjust the behavoir of the
kluctl completion
command? When loading dynamicly like this:kluctl currently prints a version check like this
Most other completion commands i know do not do this.
Steps to reproduce
No response
Relevant log output
No response
The text was updated successfully, but these errors were encountered: