Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support one order for all bidders (no PREBID_BIDDER_CODE) #18

Open
ptomasroos opened this issue Apr 24, 2017 · 6 comments · May be fixed by #91
Open

Support one order for all bidders (no PREBID_BIDDER_CODE) #18

ptomasroos opened this issue Apr 24, 2017 · 6 comments · May be fixed by #91

Comments

@ptomasroos
Copy link

In the case of not wanting to have one order per bidder rather using a global one by just targeting hb_pb we should allow a None PREBID_BIDDER_CODE

Same approach is recommended in the video tutorial how to setup prebid in DFP http://prebid.org/adops/step-by-step.html

@kmjennison kmjennison self-assigned this May 1, 2017
@kmjennison
Copy link
Owner

I agree that this would be a good improvement.

If we add this, I'd like to generalize the key-value targeting. Right now, we call dfp.create_line_items.create_line_item_config with arguments specific to hb_bidder and hb_pb. Preferably, we can just pass a dict and exclude hb_bidder when it's not set. This would also make it easier to add custom key-value targeting down the line.

@kmjennison kmjennison removed their assignment May 1, 2017
@Slind14
Copy link

Slind14 commented May 25, 2017

Agreed, this would be helpful/major time and complexity savor.

@sparklette
Copy link

I would like this too. Has someone managed to modify this such that hb_bidder is not required?

@sujithvn
Copy link

sujithvn commented Nov 5, 2017

Quick & dirty workaround:

Within create_line_items.py, changed the logicalOperator to OR and children criteria both as hp_pb

'logicalOperator': 'AND', 'children': [hb_bidder_criteria, hb_pb_criteria]
to

'logicalOperator': 'OR', 'children': [hb_pb_criteria, hb_pb_criteria]

This looks silly, but got the desired results in DFP.

image

@alberteltawil
Copy link

alberteltawil commented Jan 31, 2018

I'd love to see how I can change this behavior too. I did what @sujithvn mentioned above but it didn't seem to work as it threw an error. Anyway I can modify this tool to accept multiple BidderCodes or none? The normal behavior of Prebid is to accept multiple bidders and not to be only associated with only one (ex. AppNexus, Sovrn, IndexExchange, Rubicon, etc).

Any help would be greatly appreciated.

@mercuryyy
Copy link

Did anyone find another workaround they can share?

@kmjennison kmjennison changed the title Allow None PREBID_BIDDER_CODE Support one order for all bidders (no PREBID_BIDDER_CODE) Sep 9, 2019
jarnix pushed a commit to jarnix/dfp-prebid-setup that referenced this issue Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants