Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to remove the knative-local-gateway? #1255

Open
joke opened this issue Feb 6, 2024 · 3 comments
Open

How to remove the knative-local-gateway? #1255

joke opened this issue Feb 6, 2024 · 3 comments
Labels
triage/accepted Issues which should be fixed (post-triage)

Comments

@joke
Copy link

joke commented Feb 6, 2024

Hi,

the documentation in config-istio says the local gateway can be removed if a service mesh is in place:

# A cluster local gateway to allow pods outside of the mesh to access
# Services and Routes not exposing through an ingress.  If the users
# do have a service mesh setup, this isn't required and can be removed.

But I don't see how this can be done. If I don't specify a line like that, the default kicks in:
local-gateway.knative-serving.knative-local-gateway: "knative-local-gateway.istio-system.svc.cluster.local"

Causing this error message:
type: 'Warning' reason: 'InternalError' failed to get Gateway: gateway.networking.istio.io \"knative-local-gateway\" not found

The support for this mesh syntax has been remove in this pull request.

Regards
Joke

@dprotaso
Copy link
Contributor

dprotaso commented Feb 6, 2024

We're making tweaks to the configuration here: #1247

I wonder if it makes sense to better express no localgateway programming in that newer config once that change lands

Though at a minimum it seems like we should update the comment

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Feb 6, 2024
@joke
Copy link
Author

joke commented Feb 6, 2024

on that note: support for delegate virtual services would be cool: #1003

@dprotaso
Copy link
Contributor

dprotaso commented Feb 6, 2024

Can you comment on that issue - with your use case and how it helps you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants