Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce --https flag which will add option to run all e2e tests with different http and https settings #1520

Open
mvinkler opened this issue Nov 12, 2021 · 4 comments
Open

Introduce --https flag which will add option to run all e2e tests with different http and https settings #1520

mvinkler opened this issue Nov 12, 2021 · 4 comments
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)

Comments

@mvinkler
Copy link
Contributor

mvinkler commented Nov 12, 2021 •
edited

Feature request

Please introduce --https flag, similar to one in knative/serving: knative/serving#5157

Use case

The flag will add option to run all e2e tests with different http and https settings.
Currently, TestDomain test expects the first service to be available at http, and the second at https, but this may not be the case if "defaultExternalScheme" is set to https.
@mvinkler mvinkler added the kind/feature New feature or request label Nov 12, 2021
@rhuss rhuss added the triage/accepted Issues which should be fixed (post-triage) label Nov 17, 2021
@rhuss rhuss added the good first issue Denotes an issue ready for a new contributor. label Jan 25, 2022
@JuneOh710
Copy link

/assign

@briheet
Copy link

briheet commented Dec 23, 2023 •
edited

Hey @rhuss , if @JuneOh710 is not working on this issue, i would like to work on it as it interests me. Could you brief me a little about this ? I did look into feature request and the use case, could you touch on things where should i start with ?

@JuneOh710
Copy link

Hey @rhuss , if @JuneOh710 is not working on this issue, i would like to work on it as it interests me. Could you brief me a little about this ? I did look into feature request and the use case, could you touch on things where should i start with ?

Hello, @briheet01. I took on this issue as a part of an initiative for undergrad students. I'm actually meeting with a member of knative today at 5pm EST to discuss this issue. Would it be possible for you to let us continue working on this issue?

@briheet
Copy link

briheet commented Dec 23, 2023

@JuneOh710 Yeah sure, good luck.

@JuneOh710 JuneOh710 removed their assignment May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor. kind/feature New feature or request triage/accepted Issues which should be fixed (post-triage)
Projects
Client Planning
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@rhuss @mvinkler @JuneOh710 @briheet