Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align the --to param to comply with standard kn --sink param #282

Open
cardil opened this issue Mar 23, 2023 · 2 comments · May be fixed by knative/client-pkg#177 or knative/client#1935
Open

Align the --to param to comply with standard kn --sink param #282

cardil opened this issue Mar 23, 2023 · 2 comments · May be fixed by knative/client-pkg#177 or knative/client#1935
Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)

Comments

@cardil
Copy link
Contributor

cardil commented Mar 23, 2023

During the development of the kn event plugin, two options for sending have been implemented: --to and --to-url. Both of them are being described in this doc, in appropriate sections.

It makes sense to align both of them in single --to option, as the sink command line spec format is way easier to write than the current subject-based one. Maybe, to keep the functionality of matching resources by labels and targeting resources besides Knative, but addressable, appropriate contributions can be made to knative client itself to extend the sink spec format to accept subject-style as fallback.

Also, the --to will accept http(s) addresses.

/kind enhancement

@cardil cardil changed the title Align the --to param to comply with standard kn --sink param Align the --to param to comply with standard kn --sink param Mar 23, 2023
@cardil
Copy link
Contributor Author

cardil commented Mar 23, 2023

Splits from #222

@cardil cardil added this to the Stable release (GA) milestone Mar 23, 2023
@cardil
Copy link
Contributor Author

cardil commented Mar 23, 2023

/triage accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
1 participant