Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add election reminders to the election process #1544

Merged
merged 1 commit into from
May 22, 2024
Merged

Add election reminders to the election process #1544

merged 1 commit into from
May 22, 2024

Conversation

aliok
Copy link
Member

@aliok aliok commented Mar 26, 2024 •
edited

Changes

  • Add election reminders to the election process

/kind

Fixes #1380

Release Note

Docs

@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 26, 2024

@aliok: The label(s) kind/<kind> cannot be applied, because the repository doesn't have them.

In response to this:

Changes

  • Add election reminders to the election process

/kind

Fixes #1380

Release Note

Docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from nainaz and salaboy March 26, 2024 14:27
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2024
@aliok
Copy link
Member Author

aliok commented Apr 25, 2024

cc @dprotaso

Is it possible to set a Slack message reminder in a Gitops way?

I know TOC is sending a Slack message for reminding WGs about the status updates.

@aliok aliok mentioned this pull request Apr 25, 2024
Closed
@dprotaso
Copy link
Member

it's an action here - https://github.com/knative/community/blob/main/.github/workflows/toc-review-reminder.yaml

it reads this file - https://github.com/knative/community/blob/main/mechanics/TOC-REVIEW.schedule#L1

@aliok
Copy link
Member Author

aliok commented Apr 25, 2024

it's an action here - https://github.com/knative/community/blob/main/.github/workflows/toc-review-reminder.yaml

Thanks. I think I'll pass adding an action for election reminders that happen once a year :)

@aliok
Copy link
Member Author

aliok commented Apr 25, 2024

Can you LGTM this one?

@aliok aliok changed the title Add election reminders to the election process Add election reminders to the election processs Apr 28, 2024
@aliok aliok changed the title Add election reminders to the election processs Add election reminders to the election process Apr 28, 2024
@aliok
Copy link
Member Author

aliok commented May 22, 2024

@dprotaso lgtm?

@dprotaso
Copy link
Member

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
@knative-prow knative-prow bot merged commit dd0ccc4 into knative:main May 22, 2024
3 checks passed
@aliok aliok deleted the 2024-03-26-election-reminders branch May 23, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nainaz nainaz Awaiting requested review from nainaz

@salaboy salaboy Awaiting requested review from salaboy

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reminders for elections
2 participants
@aliok @dprotaso