Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website colour adjustments #5765

Closed
mmejia02 opened this issue Oct 19, 2023 · 16 comments · Fixed by #5980
Closed

Website colour adjustments #5765

mmejia02 opened this issue Oct 19, 2023 · 16 comments · Fixed by #5980
Assignees
Labels
good first issue help wanted triage/accepted Issues which should be fixed (post-triage)

Comments

@mmejia02
Copy link

New colours for the website were chosen to be more accessible and maintain brand consistency. The original dark and light blue used on the website are not the same ones used on the logo. The hex colours and screenshot of current website are below.

image

image

As such the blues were changed to match the logo, but the dark blue was slightly darkened to have sufficient colour contrast to be used as a background colour.

In order for the light blue to be accessible as a background we will need to change the button text to be 18.7 px. but this would be a next step.

Conclusion: Change the root website dark and light blue to the following hex codes:

Light Blue: 6593C8
Dark blue: 0D4984

@Cali0707
Copy link
Member

Thanks for opening this @mmejia02 ! Would you be able to open a similar issue in https://github.com/knative/docs so that a contributor there can work on this?

@Cali0707 Cali0707 transferred this issue from knative/ux Nov 21, 2023
@Cali0707
Copy link
Member

/good-first-issue

Copy link

knative-prow bot commented Nov 21, 2023

@Cali0707:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ReToCode
Copy link
Member

/cc @knative/steering-committee

@lavishpal
Copy link

/assign

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 23, 2024
@Cali0707
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 26, 2024
@Cali0707
Copy link
Member

/triage accepted

@knative-prow knative-prow bot added the triage/accepted Issues which should be fixed (post-triage) label Feb 26, 2024
@asr2003
Copy link
Contributor

asr2003 commented May 7, 2024

/assign

@asr2003
Copy link
Contributor

asr2003 commented May 7, 2024

@Cali0707 Could I change the entire root website dark and light blue as per mentioned HEX Codes

Light Blue: 6593C8
Dark blue: 0D4984

@Cali0707
Copy link
Member

Cali0707 commented May 7, 2024

Hey @asr2003 yeah, that sounds like a good approach to me! As a bit of help, since we are using mkdocs I would recommend checking out https://squidfunk.github.io/mkdocs-material/setup/changing-the-colors/#custom-colors for more info on how to set the root colours of the site

@asr2003
Copy link
Contributor

asr2003 commented May 9, 2024

Thanks, @Cali0707 . I have done with setup and went through the codebase to better understand current status of project after getting assign of this issue . Now I have got a brief idea about this project. I will now ahead to work on this issue and submit a PR soon .

Will follow up you in Slack for further assistance :)

@rohitsrma
Copy link
Contributor

/assign

@Cali0707
Copy link
Member

Hey @rohitsrma it looks like @asr2003 is already working on this issue. Would you be interested in working on something else instead?

@rohitsrma rohitsrma removed their assignment May 13, 2024
@rohitsrma
Copy link
Contributor

Hello @Cali0707, I'm really sorry for assigning myself.

@asr2003 I've made the changes locally to resolve this issue. So, if you need any help i would be more than happy to do.

@rash1411
Copy link

#assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants