Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate server-side apply to allow cooperating controllers #2128

Open
dprotaso opened this issue May 19, 2021 · 4 comments
Open

Investigate server-side apply to allow cooperating controllers #2128

dprotaso opened this issue May 19, 2021 · 4 comments
Assignees
@dprotaso
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@dprotaso
Copy link
Member

Refs:
https://kubernetes.io/docs/reference/using-api/server-side-apply/
knative-extensions/net-contour#347 (comment)

This would allow customization of the resources we create

/assign @dprotaso
@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 18, 2021
@dprotaso
Copy link
Member Author

dprotaso commented Sep 8, 2021

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 8, 2021
@senthilnathan senthilnathan mentioned this issue Sep 21, 2021
Closed
@dprotaso
Copy link
Member Author

dprotaso commented Dec 6, 2022

Following up here - I'm wondering if it's possible for a webhook to add defaults which the controller ignores after the fact

@dprotaso
Copy link
Member Author

dprotaso commented Jan 4, 2023

FYI there's a server-side apply bug upstream that's worth keeping tabs on - kubernetes/kubernetes#111937

I don't believe if blocks this issue

This was referenced Jan 18, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dprotaso dprotaso

Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
Serving API Roadmap
Status: In Design
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dprotaso @knative-prow-robot