Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Jaeger tracing backends #2561

Open
haubenr opened this issue Jul 26, 2022 · 7 comments
Open

Support Jaeger tracing backends #2561

haubenr opened this issue Jul 26, 2022 · 7 comments
Labels
kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@haubenr
Copy link

haubenr commented Jul 26, 2022

At the moment knative only supports tracing to Zipkin backends. It would be good to have more options, e.g. supporting Jaeger tracing backends as well (natively, without the need of external converters etc.)

/area API
/kind feature

Expected Behavior

knative support Jaeger tracing backends.

Actual Behavior

knative only supports tracing to Zipkin backends.

Steps to Reproduce the Problem

n/a

Additional Info

This issue is a follow-up to these issues that have been closed due to inactivity:

#1076
#1077

@knative-prow
Copy link

knative-prow bot commented Jul 26, 2022

@haubenr: The label(s) area/tracing cannot be applied, because the repository doesn't have them.

In response to this:

At the moment knative only supports tracing to Zipkin backends. It would be good to have more options, e.g. supporting Jaeger tracing backends as well (natively, without the need of external converters etc.)

/area tracing
/kind feature

Expected Behavior

knative support Jaeger tracing backends.

Actual Behavior

knative only supports tracing to Zipkin backends.

Steps to Reproduce the Problem

n/a

Additional Info

This issue is a follow-up to these issues that have been closed due to inactivity:

#1076
#1077

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dprotaso
Copy link
Member

dprotaso commented Jul 26, 2022

I think I'd like to support jaeger by exporting Otel traces. Jaeger as of 1.35 can directly receive them.

We do need an OpenCensus => OTel exporter - which seems to have existed before but was removed

I prodded the issue here to see if it's unblocked & possible to add back a tracing bridge

open-telemetry/opentelemetry-go#2808

edit looks like the tracing bridge still exists

https://github.com/open-telemetry/opentelemetry-go/tree/main/bridge/opencensus

@dprotaso
Copy link
Member

Note: we want to eventually swap to OTel instead of OpenCensus #855

@haubenr
Copy link
Author

haubenr commented Jul 27, 2022

Sure, sounds like the right move.

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 26, 2022
@knative-prow-robot
Copy link
Contributor

This issue or pull request is stale because it has been open for 90 days with no activity.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close

/lifecycle stale

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 26, 2022
@dprotaso
Copy link
Member

/lifecycle frozen

@knative-prow knative-prow bot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants