Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to new K8s generator scripts/go commands #2927

Open
3 tasks
ReToCode opened this issue Jan 8, 2024 · 2 comments
Open
3 tasks

Migrate to new K8s generator scripts/go commands #2927

ReToCode opened this issue Jan 8, 2024 · 2 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@ReToCode
Copy link
Member

ReToCode commented Jan 8, 2024

Context

See https://cloud-native.slack.com/archives/C04LGHDR9K7/p1704710449414709 and #2904

Possible solutions

Based on #2904 (comment) and discussions.

a) Use go run instead of scripts (downside: this does not clean up old resources)
b) Use the new k8s.io/code-generator/kube_codegen.sh
c) Wait until @cardil manages to migrate the scripts in K8s to full golang, then adapt to that solution

Todo

  • Agree on which way to go
  • Implement in pkg
  • Implement on all downstream repos
@ReToCode
Copy link
Member Author

ReToCode commented Jan 9, 2024

From the discussion in kubernetes/kubernetes#122236 it is best to wait a bit until Kubernetes figures out the new way. Until then, knative/hack#357 will help to minimize the work needed for now.

Copy link
Contributor

github-actions bot commented Apr 9, 2024

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 9, 2024
@ReToCode ReToCode added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

1 participant