Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installs of commander dependency with date 1st Jan 1970 and breaks ZIP #2531

Closed
AdrieanKhisbe opened this issue Mar 19, 2018 · 3 comments
Closed

Installs of commander dependency with date 1st Jan 1970 and breaks ZIP #2531

AdrieanKhisbe opened this issue Mar 19, 2018 · 3 comments

Comments

@AdrieanKhisbe
Copy link
Contributor

Environment

Knex version: 0.14.0
Database + version: irrelevant
OS: ubuntu + macOs

Bug

An installed version of knex cannot be zipped and then deployed. (aws lambda)

This is due to the following problem on commander dependency: tj/commander.js#777 (caused by npm bug), the files in package installed having a too old timestamp.
@elhigu
Copy link
Member

elhigu commented Mar 19, 2018

0.14.0 - 0.14.2 versions of knex should not be used... Is master broken with this too?

@elhigu elhigu closed this as completed Mar 19, 2018
@AdrieanKhisbe
Copy link
Contributor Author

My Bad, in fact we were using 0.14.4
(I mixed up 0.13.0 and 0.14.4)

@AdrieanKhisbe
Copy link
Contributor Author

A fix on commander was release, that solved the problem! :)
cf tj/commander.js#777 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elhigu @AdrieanKhisbe