Add DPI error codes for Oracle #4536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add DPI-1010 and DPI-1080 required for oracledb >=5.2.0
|
@cjbj Does this look correct? |
|
@kibertoad by eyeball, it seems fine. The full error number list is a bit over-the-top (and wouldn't be needed for new code that targets node-oracledb 5.2+), but if this case statement is only checked on error conditions, there isn't any harm. I would question whether NJS-040 should be on the list - there is no connection in this case. |
|
@vpeltola Can you drop the NJS-040? |
Removed NJS-040 based on request by @kibertoad and @cjbj
|
Removed NJS-040 as requested. |
kibertoad
approved these changes
Jul 12, 2021
|
Thanks! |
|
Released in 0.95.8 |
OlivierCavadenti
pushed a commit
to AbeonaPascha/knex
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add DPI-1010 and DPI-1080 error codes required for oracledb >=5.2.0