Improve Typing: add typescript support for deferrable, new Primary/Unique syntax #4589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeotuan
commented
Jul 29, 2021
| @@ -1908,12 +1909,16 @@ export declare namespace Knex { | |||
| uuid(columnName: string): ColumnBuilder; | |||
| comment(val: string): TableBuilder; | |||
| specificType(columnName: string, type: string): ColumnBuilder; | |||
| primary(columnNames: readonly string[], options?: Readonly<{constraintName?: string, deferrable?: deferrableType}>): TableBuilder; | |||
There was a problem hiding this comment.
New type for primary using options object
| primary(columnNames: readonly string[], constraintName?: string): TableBuilder; | ||
| index( | ||
| columnNames: string | readonly (string | Raw)[], | ||
| indexName?: string, | ||
| indexType?: string | ||
| ): TableBuilder; | ||
| unique(columnNames: readonly (string | Raw)[], options?: Readonly<{indexName?: string, deferrable?: deferrableType}>): TableBuilder; |
There was a problem hiding this comment.
Added type for unique using options object
| @@ -1908,12 +1909,16 @@ export declare namespace Knex { | |||
| uuid(columnName: string): ColumnBuilder; | |||
| comment(val: string): TableBuilder; | |||
| specificType(columnName: string, type: string): ColumnBuilder; | |||
| primary(columnNames: readonly string[], options?: Readonly<{constraintName?: string, deferrable?: deferrableType}>): TableBuilder; | |||
| /** @deprecated */ | |||
There was a problem hiding this comment.
add deprecate tag for old syntax
|
@kibertoad Hi i added type support for the the new deferrable support that was added. Also added a datetime type |
kibertoad
reviewed
Jul 29, 2021
kibertoad
approved these changes
Jul 29, 2021
OlivierCavadenti
pushed a commit
to AbeonaPascha/knex
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also addressing missing datetime missing in
close #3944