New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter nullable
constraint when alterNullable
is set to true
#4730
Conversation
Can you also add an integration test? there are few dealing with nullability in integration2, you can build from there |
This is also an issue on CockroachDB. See: strapi/strapi#11738 |
@OlivierCavadenti this might also look good in 1.0.0 |
@OlivierCavadenti before doing anything, check out this post strapi/strapi#11738 (comment) |
Can we get this merged? It's causing quite a headache for various projects depending on knex. |
@ethan-gallant tests are missing and there are conflicts. wiuld you like to help? |
I can check tomorrow I think. I need to reread the thread to understand the problem ^^. |
@OlivierCavadenti Do you think we can publish next semver minor now? |
@OlivierCavadenti as it turned out, this is irrelevant, there is a problem with the requests themselves, just a similar error |
As discussed in the #4401 Issue, I created a PR to make it so nullable alterations only apply when
({ alterNullable: true })
is provided as a param to.alter()
function (which is a default value, since we do not want to break the previous behaviour).@elhigu please help further :)