New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Union all + first syntax error (#4364) #4799

Merged

OlivierCavadenti merged 1 commit into knex:master from OlivierCavadenti:union-all-first-4364

Nov 3, 2021

Collaborator

OlivierCavadenti commented Nov 3, 2021 •

edited

Fix a syntax bug with union all and first because the (old) onlyUnion function is always false (we have a columns array with empty array for values).
Fixes UnionAll + First generates invalid SQL #4364


          Fix Union all + first syntax error (knex#4364)

1580f22

kibertoad approved these changes

View reviewed changes

OlivierCavadenti merged commit 75ece73 into knex:master

OlivierCavadenti deleted the union-all-first-4364 branch

December 20, 2021 22:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment