New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable wrapIdentifier for SQLite .hasTable #4915
Conversation
Can you add tests for this plz ? |
Hey, I came across a few bug on the test file: describe('sqlite only', () => {
if (!isSQLite(knex)) {
return Promise.resolve();
} This will never work because the |
Yes, please! Could you create one? |
Sure! Leave it to me. |
@OlivierCavadenti Could you review this? |
Released in 1.0.1. |
Currently, the
wrapIdentifier
option does not apply for SQLitedb.schema.hasTable
.For example, even if we set
wrapIdentifier
to parse identifiers to snake case, we'd get the following:This PR fixes this by enabling the wrap for SQLite Compiler:
Fix #4898