Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for RETURNING and enable them for SQLite. #4934

Merged
merged 6 commits into from Jan 16, 2022

Conversation

kibertoad
Copy link
Collaborator

Functionality doesn't seem to work yet

First pass at implementing RETURNING for sqlite
@kibertoad
Copy link
Collaborator Author

@OlivierCavadenti Could you take a look at this and see if I'm missing something and there is actually a way to get necessary data from SQLite? The way I see it,
connection[callMethod](obj.sql, obj.bindings, function (err, response) {
part of SQLite dialect is returning undefined response and we don't actually get anything back. Wonder if we need to do something additionally to make SQLite to return data for inserts.

@kibertoad
Copy link
Collaborator Author

Related ticket: microsoft/vscode-node-sqlite3#15

@OlivierCavadenti
Copy link
Collaborator

@OlivierCavadenti Could you take a look at this and see if I'm missing something and there is actually a way to get necessary data from SQLite? The way I see it, connection[callMethod](obj.sql, obj.bindings, function (err, response) { part of SQLite dialect is returning undefined response and we don't actually get anything back. Wonder if we need to do something additionally to make SQLite to return data for inserts.

Like you I made some tests and I dont find anything to get back the results... maybe something missing in the library.

@kibertoad
Copy link
Collaborator Author

@OlivierCavadenti I will restore warnings for 1.0.0 then, and hopefully we'll get some response from vscode sqlite team
I'll also try with better-sqlite, maybe that one works.

@kibertoad kibertoad marked this pull request as ready for review January 15, 2022 23:29
@kibertoad kibertoad merged commit 4a0d82f into master Jan 16, 2022
@kibertoad kibertoad deleted the feat/sqlite-returning branch January 16, 2022 00:20
@OlivierCavadenti
Copy link
Collaborator

@kibertoad this can be reimplemented since we have the old-new sqlite3 package :D.

@kibertoad
Copy link
Collaborator Author

Will take a look if they expose necessary data now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants