Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of MATERIALIZED and NOT MATERIALIZED with WITH/CTE #4940

Merged
merged 4 commits into from Jan 20, 2022
Merged

Support of MATERIALIZED and NOT MATERIALIZED with WITH/CTE #4940

merged 4 commits into from Jan 20, 2022

Conversation

OlivierCavadenti
Copy link
Collaborator

@kibertoad
Copy link
Collaborator

Can you also add an integration test which would actually run the sql?

@vorandrew
Copy link

#4948 alternative version

@OlivierCavadenti
Copy link
Collaborator Author

@kibertoad I push a fix of unit test :D :

image

@OlivierCavadenti OlivierCavadenti mentioned this pull request Jan 20, 2022
Merged
@OlivierCavadenti OlivierCavadenti merged commit 6398098 into knex:master Jan 20, 2022
@OlivierCavadenti OlivierCavadenti deleted the with-materialized-4470 branch January 20, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suppport "MATERIALIZED" and "NOT MATERIALIZED" modifiers on WITH/CTE
3 participants
@OlivierCavadenti @kibertoad @vorandrew