Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix argument type of alter method #4996

Merged
merged 1 commit into from Feb 2, 2022
Merged

Fix argument type of alter method #4996

merged 1 commit into from Feb 2, 2022

Conversation

rafaelalmeidatk
Copy link
Contributor

Fixes #4995. Let me know if I need to add anything more to the PR

OlivierCavadenti
OlivierCavadenti approved these changes Feb 2, 2022
View reviewed changes
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the issue + PR !

@OlivierCavadenti OlivierCavadenti merged commit a31129b into knex:master Feb 2, 2022
@OlivierCavadenti OlivierCavadenti mentioned this pull request Feb 2, 2022
Merged
@rafaelalmeidatk rafaelalmeidatk deleted the fix-alter-args-type branch February 2, 2022 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TS] alter() requires 1 argument
2 participants
@rafaelalmeidatk @OlivierCavadenti