Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add withMaterialized and withNotMaterialized to method-constants #5009

Merged
merged 1 commit into from Feb 7, 2022
Merged

Add withMaterialized and withNotMaterialized to method-constants #5009

merged 1 commit into from Feb 7, 2022

Conversation

jhiesey
Copy link
Contributor

@jhiesey jhiesey commented Feb 7, 2022

Fixes #5008

OlivierCavadenti
OlivierCavadenti approved these changes Feb 7, 2022
View reviewed changes
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks ! @kibertoad go for 1.0.3 or you think about another thing to add ?

@OlivierCavadenti OlivierCavadenti merged commit d956aec into knex:master Feb 7, 2022
@jhiesey jhiesey deleted the add-materialized-to-method-constants branch February 8, 2022 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withMaterialized and withNotMaterialized are not present on knex object
2 participants
@jhiesey @OlivierCavadenti