Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Union Wrapping #5030

Merged
merged 8 commits into from Mar 7, 2022
Merged

Conversation

OlivierCavadenti
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti commented Feb 19, 2022

@OlivierCavadenti OlivierCavadenti marked this pull request as draft February 19, 2022 19:10
@OlivierCavadenti
Copy link
Collaborator Author

OlivierCavadenti commented Feb 21, 2022

I change wrap logic (main query is wrapped when union query are wrapped) but I still need to investigate how to generate valid SQL with limit, group by, etc. in unions (not so trivial).

@OlivierCavadenti OlivierCavadenti marked this pull request as ready for review March 6, 2022 18:00
@OlivierCavadenti OlivierCavadenti changed the title Rework Union to fix problems with groupby, ... Rework Union Wrapping Mar 6, 2022
@OlivierCavadenti OlivierCavadenti requested review from kibertoad and removed request for kibertoad March 6, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

union/union all bug wrapped queries group by problems in union query
2 participants