Implement extendable builders #5041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DominicVonk I like your PR, but I'm sure it won't pass without tests |
you are right :D |
|
The unit test is added |
|
@OlivierCavadenti can you check the pr? |
|
Linting and types fails @DominicVonk |
|
Is this planned to be merged? |
kibertoad
reviewed
May 17, 2022
| @@ -41,7 +41,7 @@ class MigrationGenerator { | |||
|
|
|||
| _getNewMigrationName(name) { | |||
| if (name[0] === '-') name = name.slice(1); | |||
| return yyyymmddhhmmss() + '_' + name + '.' + this.config.extension; | |||
| return yyyymmddhhmmss() + '_' + name + '.' + this.config.extension.split('-')[0]; | |||
There was a problem hiding this comment.
Was this an intended change?
There was a problem hiding this comment.
Yes this change was intended, I added 2 stub's for js-schema / ts-schema, and the split is to only preserve the .ts / .js part
kibertoad
approved these changes
May 17, 2022
|
@DominicVonk Can you also submit documentation PR to https://github.com/knex/documentation? |
|
When will this be released to a new version? |
|
Released in 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #4555
Can you merge this? @kibertoad