Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to better-sqlite3 #5097

Closed
eikaramba opened this issue Apr 1, 2022 · 3 comments · Fixed by #5136
Closed

switch to better-sqlite3 #5097

eikaramba opened this issue Apr 1, 2022 · 3 comments · Fixed by #5136

Comments

@eikaramba
Copy link

currently the default sqlite driver is @vscode/sqlite3, however that does not provide prebuilt binaries and will possible vanish see microsoft/vscode-node-sqlite3#16 (comment)

a better alterantive is to switch to better-sqlite3 as the default driver, which is already supported by knex.

alternatively if i am correct one could wait for the mapbox to fix the vulnerabilites, however that does not seem to happen soon TryGhost/node-sqlite3#1493

original pull request for using @vscode/sqlite3 #4866

@kibertoad
Copy link
Collaborator

We definitely should consider that for 2.0.0

@NilsBaumgartner1994
Copy link

push, we also face this problem

@carlosfaria94
Copy link

carlosfaria94 commented Apr 13, 2022

Ghost team have taken the development of node-sqlite3! All the problems are fixed in their recent version!

https://github.com/TryGhost/node-sqlite3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants