Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore sqlite3 package #5136

Merged
merged 4 commits into from Apr 21, 2022
Merged

Restore sqlite3 package #5136

merged 4 commits into from Apr 21, 2022

Conversation

OlivierCavadenti
Copy link
Collaborator

@OlivierCavadenti OlivierCavadenti commented Apr 21, 2022 •
edited

@OlivierCavadenti
Restore sqlite3 package
540ceef 
- Restore the sqlite3 package since is again maintained.
@coveralls
Copy link

coveralls commented Apr 21, 2022 •
edited

Coverage Status

Coverage increased (+0.003%) to 92.28% when pulling b8df7f4 on OlivierCavadenti:restore-sqlite3 into 3279e87 on knex:master.

@kibertoad
Copy link
Collaborator

Can you also add entry to MIGRATION.md?
also needs documentation update.

@OlivierCavadenti OlivierCavadenti mentioned this pull request Apr 21, 2022
Merged
@OlivierCavadenti OlivierCavadenti merged commit b8fc16f into knex:master Apr 21, 2022
@OlivierCavadenti OlivierCavadenti deleted the restore-sqlite3 branch April 21, 2022 17:05
@kibertoad
Copy link
Collaborator

I'll cut a new release today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore node-sqlite3 support switch to better-sqlite3
3 participants
@OlivierCavadenti @coveralls @kibertoad