Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update type definitions for pg connection #5139

Merged
merged 3 commits into from May 22, 2022
Merged

Update type definitions for pg connection #5139

merged 3 commits into from May 22, 2022

Conversation

JoelVenable
Copy link
Contributor

Fixes #5124.

@coveralls
Copy link

coveralls commented Apr 21, 2022 •
edited

Coverage Status

Coverage decreased (-0.04%) to 92.233% when pulling 91ebb1a on JoelVenable:master into 3279e87 on knex:master.

OlivierCavadenti
OlivierCavadenti requested changes Apr 21, 2022
View reviewed changes
types/index.d.ts Outdated
options?: string;
}

type PgGetTypeParser = (oid: number, format: string) => any
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

miss ";"

kibertoad
kibertoad reviewed May 22, 2022
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
@kibertoad kibertoad merged commit d671288 into knex:master May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@OlivierCavadenti OlivierCavadenti OlivierCavadenti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Postgres connection definitions out of date
4 participants
@JoelVenable @coveralls @kibertoad @OlivierCavadenti