Added getDialectByNameOrAlias and converted repo to use it. #5142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous this repo has imported Dialect objects via dynamically generating a string to require. This does not work well with compilers like ncc. To solve this and make for a better development experience we add the function `getDialectByNameOrAlias` to safely import Dialects while making requirement paths static for better compiler and bundler experiences.
kibertoad
reviewed
Apr 22, 2022
| @@ -0,0 +1,35 @@ | |||
| const { resolveClientNameWithAliases } = require('../util/helpers'); | |||
|
|
|||
| const dbNameToDialectLoader = Object.freeze({ | |||
There was a problem hiding this comment.
Just trying to follow repo standards. I saw Object.freeze(...) was used for other constants. Happy to remove if preferred or change to all caps :)
kibertoad
approved these changes
Apr 22, 2022
|
Released in 2.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous this repo has imported Dialect objects via dynamically generating a string to require. This does not work well with compilers like ncc. To solve this and make for a better development experience we add the function
getDialectByNameOrAliasto safely import Dialects while making requirement paths static for better compiler and bundler experiences.