Use correct paths in package.json browser field #5174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The seeder entry is the only one really required to easily build knex for the browser without shimming `fs`, but I updated the migrations path to match. However, there's also `lib/migrations/seed/seed-stub.js`, which actually seems to provide errors when attempting to use the seed functionality in a browser, but isn't actually used anywhere I'm not exactly sure which way is intended.
kibertoad
approved these changes
May 22, 2022
|
Thank you! |
|
but what about the seed stub? |
|
It was introduced a long time ago, I'm not entirely sure. Probably updating it to be on a safe side makes sense. |
|
what do you mean updating it? It should either be used in place of the noop stub or deleted shouldn't it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The seeder entry is the only one really required to easily build knex for
the browser without shimming
fs, but I updated the migrations path tomatch.
However, there's also
lib/migrations/seed/seed-stub.js, which actuallyseems to provide errors when attempting to use the seed functionality in
a browser, but isn't actually used anywhere
I'm not exactly sure which way is intended.
If the seed stub is intended, then I'll change it to use that, otherwise it should probably be removed.