Add ability to prepend query comments #5289
Merged
+195
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I fixed a bug with cockroachdb as ids are not numeric. It should be fine now. I'll squash commit later. |
|
@francois2metz Can you please send documentation PR to https://github.com/knex/documentation? |
|
@kibertoad Hi! I created the documentation PR: knex/documentation#450 |
francois2metz
force-pushed
the
feature/query_comment
branch
from
5de6b94 to
0c0a4f5
Compare
francois2metz
force-pushed
the
feature/query_comment
branch
3 times, most recently
from
c4b5b2f to
3890007
Compare
Co-authored-by: François de Metz <francois@2metz.fr>
francois2metz
force-pushed
the
feature/query_comment
branch
from
3890007 to
2b35c73
Compare
JMHenri
approved these changes
Mar 20, 2023
OlivierCavadenti
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Update types here and I will merge it:
https://github.com/knex/knex/blob/master/types/index.d.ts
OlivierCavadenti
approved these changes
Apr 14, 2023
|
Very excited for this! Any ETA on when a new version will be released? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebased and updated version of #2815 that fixes #1982.
About parameter binding, I did tried to escape them, but I doesn't works for mysql. So I forbidden any ?.