Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing comments on delete, update and insert #5738

Merged
merged 7 commits into from Nov 28, 2023

Conversation

sebastienroul
Copy link
Contributor

Few monthes ago comments where included in query, but only in select statement. Here is the code to make delete, update and insert compatible with comments

Few monthes ago comments where included in query, but only in select statement. Here is the code to make delete, update and insert compatible with comments
@kibertoad
Copy link
Collaborator

@sebastienroul could you please add tests?

@sebastienroul
Copy link
Contributor Author

@kibertoad Hi, yes sure, but can you give me pointer to the test written for the select statement please, I cant find them (µI'd like to use them as template). For your info PR is working like a charm on 10 of our projects :)

@sebastienroul
Copy link
Contributor Author

@kibertoad : Finally, unit test + integration test are there.
I clear my first attempt to modify all dialect, and focus only on MYSQL. Everything is green... let pull :)

@coveralls
Copy link

coveralls commented Nov 15, 2023

Coverage Status

coverage: 92.782% (+0.004%) from 92.778%
when pulling 4159434 on sebastienroul:patch-1
into 1d7707e on knex:master.

@kibertoad kibertoad merged commit 57419fb into knex:master Nov 28, 2023
25 of 30 checks passed
@kibertoad
Copy link
Collaborator

thanks!

@kibertoad
Copy link
Collaborator

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants