Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import knex as type in TS migration template #5741

Merged
merged 2 commits into from Nov 28, 2023
Merged

Import knex as type in TS migration template #5741

merged 2 commits into from Nov 28, 2023

Conversation

OliverWales
Copy link
Contributor

To match @typescript-eslint/consistent-type-imports eslint rule.

@coveralls
Copy link

coveralls commented Nov 27, 2023 •
edited

Coverage Status

coverage: 92.778%. remained the same
when pulling 05fed37 on OliverWales:import-knex-as-type
into 1d7707e on knex:master.

@kibertoad kibertoad merged commit af0e9c1 into knex:master Nov 28, 2023
23 of 29 checks passed
@kibertoad
Copy link
Collaborator

Thanks!

@kibertoad
Copy link
Collaborator

Released in 3.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@OliverWales @coveralls @kibertoad