New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query doesn't work with .stream()
if options not exists
#6028
Comments
Can you create a pr to fix this? |
Shure 🙂 |
Finished tests, and okay for oracledb driver (PR #6040) but a question arose here. In this case i solved only for oracledb driver! I see example used on mysql knex/lib/dialects/mysql/index.js Lines 104 to 107 in aedba5e
But maybe it's interesting fix this on here where stream options is {} with default for all drivers? Lines 157 to 160 in aedba5e
stream(connection, queryParam, stream, options = {}) { or this is a bad idea? Thanks :) @rluvaton |
Environment
Knex version: 3.1.0
Database + version: Oracle 18c
OS: Windows (WSL Ubuntu 22.04)
Bug
Example: (with first case, never join
.on('data')
)If is optional parameters is should not a impeditive for use
.pipe()
.on()
The text was updated successfully, but these errors were encountered: