New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement AES-GCM #222

Open

2 tasks

Bloodchiefy opened this issue Jan 12, 2022 · 0 comments

Labels

core improvement

Contributor

Bloodchiefy commented Jan 12, 2022

To ensure data authenticity, integrity and confidentiality, the suggestion was, to use AES-GCM.
For that, probably the Encrcyptor and Decryptor (defined: https://github.com/knoxite/knoxite/blob/master/encryption.go) should be extended.

Open for Discussion is the following:

Should AES-GCM exist alongside AES or other symetric ciphers?
Should then the user be allowed to select a cipher (with AES-GCM as default)?

As a reference for implementing AES-GCM, I found this: https://gist.github.com/dakait/8f78312997611617f26430d07ffe5dc3

Bloodchiefy added improvement core labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment