Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow support for custom Http client #49

Open
kaal-dam opened this issue Apr 9, 2021 · 0 comments
Open

Allow support for custom Http client #49

kaal-dam opened this issue Apr 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@kaal-dam
Copy link

kaal-dam commented Apr 9, 2021

Is your feature request related to a problem? Please describe.
We use a custom http client in our project for things like performance metrics and analysis and would like to be able to use it with our Algolia query too.

Describe the solution you'd like
right now you use the standard http.post method from the http package, that method is actually a shortcut for a call to Client().post from the same package. The same is true for the others method of the package.
Adding an optional parameter for a custom Client to method like getObjects and replacing call to http.post by a call to this custom client.post when the custom client is available would likely solve this problem.

Describe alternatives you've considered
We tried to use our current performance monitoring by encapsulating our call to this library in it but we haven't managed yet to have functional traces on Firebase Performance for example, that's why we decided to ask for this feature.
It also had the issue of partial code duplication between our custom Http Client and this encapsulation.

@kaal-dam kaal-dam added the enhancement New feature or request label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant