Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Actions is not a TTY and cannot run crossterm tests #57

Closed
zontasticality opened this issue Apr 5, 2024 · 1 comment · Fixed by #58
Closed

Github Actions is not a TTY and cannot run crossterm tests #57

zontasticality opened this issue Apr 5, 2024 · 1 comment · Fixed by #58
Assignees

Comments

@zontasticality
Copy link
Collaborator

Failing CI: https://github.com/knoxy5467/a-better-notion/actions/runs/8563468559/job/23468543779#step:7:676

See: actions/runner#241
Crossterm issue: crossterm-rs/crossterm#580

Options 1: Disable the tests if on actions CLI and sprinkle #[coverage(off] as needed.

Option 2: Figure out if there is a way around it that doesn't massively increase CI build time (docker? nixos CI?)

@zontasticality
Copy link
Collaborator Author

Figured out a way around the issue by abstracting over ratatui's backend as opposed to crossterm's writer. Added #[coverage(off)] to everything that couldn't be tested. (main, term, logging, hooks, etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants