Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rotate class id when branch more than 8 #3150

Merged

Conversation

faisalarbain
Copy link
Contributor

馃搼 Summary

Arrow are not visible when total branches more than 8. The issue also reported in ticket below:
Resolves #3149

馃搹 Design Decisions

The fix is following current implementation for branch tag's color under drawBranches methods where it adjustIndexForTheme by deducting with 8 (magic number)

I extract the magic number into const to make it easy to refactor/change the value in future.

Screenshot

This is using snippet provided in #3149

SCR-20220618-p0r

@faisalarbain
Copy link
Contributor Author

faisalarbain commented Jun 20, 2022

i not sure why static analysis is failing. can someone advise?

@faisalarbain
Copy link
Contributor Author

@sidharthv96 changed as per comment.

@sidharthv96
Copy link
Member

@faisalarbain please add a snapshot test in cypress/e2e/rendering/gitGraph.spec.js

@faisalarbain faisalarbain force-pushed the bug/3149_gitgraph_more_than_8_branches branch from cfe12f7 to 1868ae1 Compare June 23, 2022 23:36
@faisalarbain
Copy link
Contributor Author

@sidharthv96 added and rebased

@Yash-Singh1 Yash-Singh1 changed the title rotate class id when branch more than 8 fix: rotate class id when branch more than 8 Jun 29, 2022
@mclate
Copy link

mclate commented Jul 7, 2022

Is there any roadmap or eta on when this one can be merged?

@faisalarbain faisalarbain force-pushed the bug/3149_gitgraph_more_than_8_branches branch from 1868ae1 to 9ee43c0 Compare August 1, 2022 11:42
@faisalarbain
Copy link
Contributor Author

faisalarbain commented Aug 1, 2022

rebase to resolve conflict. but some test were break not related to the changes

@knsv
Copy link
Collaborator

knsv commented Aug 4, 2022

Thanks @faisalarbain! Merging!

@knsv knsv merged commit 3054a80 into mermaid-js:develop Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Git graph with more than 8 branches are not working properly
5 participants