Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: De-duplicates dependencies #3167

Merged
merged 1 commit into from Jun 23, 2022

Conversation

tommoor
Copy link
Contributor

@tommoor tommoor commented Jun 21, 2022

馃搼 Summary

Removes over 50 duplicate dependencies by specifying yarn resolutions for dagre-d3 which hasn't been updated in 3 years.

Resolves #3166

馃搵 Tasks

Make sure you

  • 馃摉 have read the contribution guidelines
  • 馃捇 have added unit/e2e tests (if appropriate)
  • 馃敄 targeted develop branch

Copy link
Member

@sidharthv96 sidharthv96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

There is ~8.3% reduction in the minimized files and all our tests pass. LGTM.

@tommoor
Copy link
Contributor Author

tommoor commented Jun 23, 2022

I'm not a collaborator so will need someone else to hit merge and release

@mmorel-35 mmorel-35 merged commit 673b375 into mermaid-js:develop Jun 23, 2022
sidharthv96 added a commit that referenced this pull request Jun 28, 2022
* origin/develop: (24 commits)
  Updated the release version to 9.1.4
  Better balance check
  chore(deps-dev): bump @commitlint/config-conventional (#3179)
  chore(deps-dev): bump lint-staged from 13.0.2 to 13.0.3 (#3177)
  chore(deps-dev): bump cypress from 10.1.0 to 10.2.0 (#3178)
  chore(deps-dev): bump @commitlint/cli from 17.0.2 to 17.0.3 (#3180)
  chore: update browsers list
  fix: typo for source
  fix: typo in cypress
  Add dev install section in contributing.md
  update doc typos/clarity (#3145)
  Update links to `mermaid.live` (#3163)
  fix #3019 Add word boundary to FK&PK. (#3168)
  Run testomatio only for PRs within org. (#3165)
  chore(deps): bump got from 11.8.3 to 11.8.5 (#3172)
  fix: De-duplicates dependencies (#3167)
  Updated allowed characters to accomodate fonts and rgba colors
  fix: Typo for documents and comments
  Sanitizsation of incoming variables that are added to the userStyles
  Only allowing a subset of characters in themeVariables
  ...
sidharthv96 added a commit to sidharthv96/mermaid that referenced this pull request Jun 30, 2022
* origin/master: (789 commits)
  Updated the release version to 9.1.4
  Better balance check
  chore(deps-dev): bump @commitlint/config-conventional (mermaid-js#3179)
  chore(deps-dev): bump lint-staged from 13.0.2 to 13.0.3 (mermaid-js#3177)
  chore(deps-dev): bump cypress from 10.1.0 to 10.2.0 (mermaid-js#3178)
  chore(deps-dev): bump @commitlint/cli from 17.0.2 to 17.0.3 (mermaid-js#3180)
  chore: update browsers list
  fix: typo for source
  fix: typo in cypress
  Add dev install section in contributing.md
  update doc typos/clarity (mermaid-js#3145)
  Update links to `mermaid.live` (mermaid-js#3163)
  fix mermaid-js#3019 Add word boundary to FK&PK. (mermaid-js#3168)
  Run testomatio only for PRs within org. (mermaid-js#3165)
  chore(deps): bump got from 11.8.3 to 11.8.5 (mermaid-js#3172)
  fix: De-duplicates dependencies (mermaid-js#3167)
  Updated allowed characters to accomodate fonts and rgba colors
  fix: Typo for documents and comments
  Sanitizsation of incoming variables that are added to the userStyles
  Only allowing a subset of characters in themeVariables
  ...
@tommoor
Copy link
Contributor Author

tommoor commented Feb 16, 2023

Hey folks, just wanted to let you know that 9.3.0 was much smaller but the build size immediately went back again in 9.4.0.

image

https://bundlephobia.com/package/mermaid@9.3.0

@sidharthv96
Copy link
Member

image

Seems like elk is the culprit. But elk will only be loaded if necessary. So it shouldn't affect most users. Will investigate.

@sidharthv96
Copy link
Member

@tommoor size is back down in 9.4.2-rc.1
The actual size is much smaller as elk and cytoscape are dynamic imports which are only used if the corresponding diagram is loaded.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate dependencies bloating bundle size
3 participants