Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xlink attribute is not set for all diagrams #3184

Closed
sidharthv96 opened this issue Jun 28, 2022 · 0 comments · Fixed by #3185
Closed

xlink attribute is not set for all diagrams #3184

sidharthv96 opened this issue Jun 28, 2022 · 0 comments · Fixed by #3185
Assignees
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@sidharthv96
Copy link
Member

Describe the bug
svg.attr('xmlns:xlink', 'http://www.w3.org/1999/xlink'); or similar code is only present in few diagrams.
So other diagrams cause this issue mermaid-js/mermaid-live-editor#796

To Reproduce
Steps to reproduce the behavior:

  1. Go to link
  2. Click on Download SVG
  3. Open SVG
  4. See error

Expected behavior
No error

Additional context
Issue is fixed using a patch in live editor. But it's best that mermaid exports compliant diagrams.

@sidharthv96 sidharthv96 added Type: Bug / Error Something isn't working or is incorrect Status: Triage Needs to be verified, categorized, etc labels Jun 28, 2022
@sidharthv96 sidharthv96 self-assigned this Jun 28, 2022
mmorel-35 pushed a commit that referenced this issue Jul 3, 2022
* fix #3184: Inject xlink in mermaidAPI.

* fix static analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant